HomePhabricator

[FEAT] Rewrite commit message validator
614857353185Unpublished

Authored by XZise on Jul 27 2017, 12:11 PM.

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.
This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

[FEAT] Rewrite commit message validator

It converts the module wide functions into a class which acts as an iterator
which can internally store information. This allows each line check to
actually know "outside information" without the need of module wide variables,
like whether it is inside the footer or whether a change id already occurred.

This also converts all of the checks into yields, so that it is unnecessary to
manually create an error message. There also changes to the logic to make sure
that the line numbers are sequential.

Change-Id: If77a0abc8c46334e6ebbf415140c12375a4870f8

Details

Committed
XZiseJul 27 2017, 12:11 PM
Parents
rICMV9b3d907af76d: build: Test against py36 if available
Branches
Unknown
Tags
Unknown
ChangeId
If77a0abc8c46334e6ebbf415140c12375a4870f8