HomePhabricator

Update patch set 1
a7c302be98c0Unpublished

Authored by XZise on Aug 17 2017, 9:14 PM.

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

Update patch set 1

Patch Set 1: Code-Review-1

I'm not sure this is actually a “valid” test. Internally the validator should only use text (aka unicode in Python 2 or str in Python 3). So the test actually would need to properly decode the file into text. And it is not testing if Ib81b572 actually works, because that part isn't actually tested.

Now maybe we could make a test repo with those commits and then simulate running it. As a matter of fact I might have some patches (depending on If77a0ab unfortunately) which might make it easier to test any commit in any repo.

Patch-set: 1
Reviewer: XZise <1838@e9e9afe9-4712-486d-8885-f54b72dd1951>
Label: Code-Review=-1

Details

Committed
Gerrit Code Review <gerrit@wikimedia.org>Aug 17 2017, 9:14 PM
Parents
rICMV0db2bb577570: Update patch set 1
Branches
Unknown
Tags
Unknown
ChangeId
None

Event Timeline

Gerrit Code Review <gerrit@wikimedia.org> committed rICMVa7c302be98c0: Update patch set 1 (authored by XZise).Aug 17 2017, 9:14 PM

Empty Commit

This commit is empty and does not affect any paths.