HomePhabricator

Add GitLabMessageValidator

Description

Add GitLabMessageValidator

Add a MessageValidator and detection logic for gitlab.wikimedia.org
hosted repos. The validator is using a sub set of the
GerritMessageValidator tests.

Tests applied:

  • S1: First line should be <=80 characters
  • S2: Do not define bug in the subject
  • B1: No line >100 characters (unless it is only a URL)
  • F1: No blank lines allowed between footer lines
  • F2: No '^Name: value$' lines allowed in body for expected footers
  • F3: Unexpected footer name
  • F4: Normalize footer names
  • F5: Expect one space after ':' following footer name
  • F6: Phabricator task id expected with Bug: footers
  • F8: Unexpected footer line
  • C1: Second line should be empty if present
  • C3: A cherry-pick description should be the last line if present

Bug: T339307

Details

Provenance
bd808Authored on Jun 30 2023, 5:11 PM
Parents
rICMVe29d183045c6: Use "subject" and "footer" terms consistently
Branches
Unknown
Tags
Unknown
ChangeId
None