Diffusion integration-commit-message-validator f9bfb67cf64b

Refactor into rules based system
f9bfb67cf64b
Actions

Tags

None

Referenced Files

None

Subscribers

None

Description

Refactor into rules based system

Prepare for adding a third validator variant by refactoring the existing
system to favor composition over inheritance when reusing individual
tests.

Add a RulesMessageValidator that uses LineRule and CommitRule tests to validate a commit message.
Reimplement GerritMessageValidator and GitHubMessageValidator as RulesMessageValidator subclasses.
Add a ValidationFailure class to describe detected errors
Update MessageValidator to expect ValidationFailure responses

Details

Provenance

Authored on Jun 29 2023, 10:50 PM

Parents

rICMV266daddd5880: gerrit: Use "subject" rather than "header"

Branches

Unknown

Tags

Unknown

ChangeId

None

Event Timeline

bd808 committed rICMVf9bfb67cf64b: Refactor into rules based system (authored by bd808).Jun 30 2023, 12:05 AM

bd808 mentioned this in T351253: Add support for GitLab markdown linebreak requirement.Tue, Nov 14, 11:43 PM

bd808 mentioned this in T195060: Make rules and MessageValidator configurable.Tue, Nov 21, 1:08 AM

Changes (16)

Path

Size

src/

commit_message_validator/

validators/

	core.py
	abstract.py

tests/

data/

GerritMessageValidator/

check_message_errors.out

short_two_lines.out

test_GerritMessageValidator.py

	test_RulesMessageValidator.py
	test_GerritMessageValidator.py

test_commit_message_validator.py

test_message_validator.py

rICMVf9bfb67cf64b

HISTORY.rst

Loading...

src/commit_message_validator/init.py

Loading...

src/commit_message_validator/validators/init.py

Loading...

src/commit_message_validator/validators/abstract.py

Loading...

src/commit_message_validator/validators/basic.py

Loading...

src/commit_message_validator/validators/core.py

Loading...

src/commit_message_validator/validators/gerrit.py

Loading...

src/commit_message_validator/validators/github.py

Loading...

src/commit_message_validator/validators/rules.py

Loading...

tests/data/GerritMessageValidator/check_message_errors.out

Loading...

tests/data/GerritMessageValidator/short_two_lines.out

Loading...

tests/test_GerritMessageValidator.py

Loading...

tests/test_RulesMessageValidator.py

Loading...

tests/test_commit_message_validator.py

Loading...

tests/test_message_validator.py

Loading...

tox.ini

Loading...