HomePhabricator

Updated mediawiki/extensions Project: mediawiki/extensions/Flow…

Description

Updated mediawiki/extensions Project: mediawiki/extensions/Flow c2637166a898c20acb64ad747a457f794d72d785

Don't log exception when missing permissions, just ignore it

formatApi() fails on a couple of occasions, one of which being when
a user has insufficient permissions. That's an "acceptable" error:
we shouldn't log it, just ignore that row.
Some places already counter this by first checking permissions, then
passing it off to formatApi() - if that one fails, it's not a
permission issue & we should log the failure.
Let's just throw an exception right away if it's a real error case,
and return false if it's a "this is no error but we can't show you
the data" case. Makes dealing with this simpler.

One potential regression: this formatApi function is not just called
from RC, Contribs, ... formatters, but also in other places
(everywhere...), so adding a new exception in there might break
those other places.
The first check was already being logged if it was being hit, and I
couldn't find it in the logs; so pretty sure we won't see it happen.

Change-Id: Icb26b999f16e591fccadb9dce2913e55d50bb7a2

Details

Provenance
jenkins-botAuthored on
Gerrit Code ReviewCommitted on May 28 2015, 6:50 PM
Parents
rMEXTffba5a2f2bf1: Updated mediawiki/extensions Project: mediawiki/extensions/Gadgets…
Branches
Unknown
Tags
Unknown
ChangeId
Icb26b999f16e591fccadb9dce2913e55d50bb7a2

Event Timeline

Gerrit Code Review <gerrit@wikimedia.org> committed rMEXT04483f1b7d3f: Updated mediawiki/extensions Project: mediawiki/extensions/Flow… (authored by jenkins-bot <jenkins-bot@gerrit.wikimedia.org>).May 28 2015, 6:50 PM