HomePhabricator

Updated mediawiki/extensions Project: mediawiki/extensions/Echo…

Description

Updated mediawiki/extensions Project: mediawiki/extensions/Echo d3bfc5a5b9ed737d46cabdb73d75095504d7a555

Improve signature detection

Previously, there were a couple of hacks in play.
It was also not picking up ~~~ (signature without timestamp)
And it relied an a nasty regular expression which, although
based on Parser, may some day get out of date.
And it relied heavily on a specific signature format, which
isn't guaranteed (it's an i18n msg)

This patch changes the approach: it will use a very simple
regex to match links, and will send those through Parser to
generate the signature anew. My reasoning is that that should
be exactly the same as what Echo just received (should've
also gone through parser)

Biggest discomfort of this approach is that it's much stricter.
It should still match whatever it generated from a ~~~ or ~~~~,
but no longer the e.g. not-real signatures we were doing in
our tests. Also had to update our tests, because signatures
change depending on anon. So I had to generate all the users.
And fix some of the signature formats used in the tests.

Bug: T75426
Bug: T87852
Bug: T75366
Bug: T78424
Change-Id: Ibeff36397129fdd5d376f3668a23a45f9a014525

Details

Provenance
jenkins-botAuthored on
Gerrit Code ReviewCommitted on Feb 6 2015, 1:21 AM
Parents
rMEXT67cfcf16d0f7: Updated mediawiki/extensions Project: mediawiki/extensions/EventLogging…
Branches
Unknown
Tags
Unknown
ChangeId
Ibeff36397129fdd5d376f3668a23a45f9a014525

Event Timeline

Gerrit Code Review <gerrit@wikimedia.org> committed rMEXT0f49d93f7d8a: Updated mediawiki/extensions Project: mediawiki/extensions/Echo… (authored by jenkins-bot <jenkins-bot@gerrit.wikimedia.org>).Feb 6 2015, 1:21 AM