HomePhabricator

Updated mediawiki/extensions Project: mediawiki/extensions/Flow…

Authored by jenkins-bot <jenkins-bot@gerrit.wikimedia.org>.

Description

Updated mediawiki/extensions Project: mediawiki/extensions/Flow bbc80c11155c780a6cdf51d7ee5d5bc8437285e8

Fix TopicHistoryStorage, which is used when no cache applies

We fall back to database (instead of cache) in 2 cases:

  • index applies but some data is missing, in which case it's fetched by backingStoreFindMulti
  • no index applies (e.g. out of range - only first x entries are cached) in which case it's fetched from storage::findMulti

Which means that findMulti can be called directly, with the exact
same $queries we send to cache indices (TopicHistoryIndex)
TopicHistoryIndex was doing some manipulations: it would expect a bogus
primary key "topic_root_id" and figure out the real queries from there.
However, the storage counterpart was never properly addressed.
I've moved the resolution code to TopicHistoryStorage, which can now
also deal with "topic_root_id". The original code in TopicHistoryIndex
has been replaced with a simple call to the code that's now been moved.

Bug: T91916
Change-Id: Icce032b04817d75ec322c24ce1e6b611c8d1c1ca

Details

Committed
Gerrit Code ReviewMay 13 2015, 7:26 PM
Parents
rMEXT2192e76e21e2: Updated mediawiki/extensions Project: mediawiki/extensions/Flow…
Branches
Unknown
Tags
Unknown
ChangeId
Icce032b04817d75ec322c24ce1e6b611c8d1c1ca

Event Timeline

Gerrit Code Review <gerrit@wikimedia.org> committed rMEXTd67dc195b21c: Updated mediawiki/extensions Project: mediawiki/extensions/Flow… (authored by jenkins-bot <jenkins-bot@gerrit.wikimedia.org>).May 13 2015, 7:26 PM