HomePhabricator

Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase…

Authored by jenkins-bot <jenkins-bot@gerrit.wikimedia.org>.

Description

Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase ddb7e9bef8e9d852e259c045b9befef94fc22eaf

Add empty span for indicators to the snakview

Advantages of this solution:

  • It works everywhere, in main snaks, qualifiers and references.
  • It's independent from the skin and the planned redesign because it simply inlines smoothly with the value.

Disadvantages:

  • It's the same class name for all indicator elements. You need a good CSS selector to target the correct element. Shouldn't be that hard: start with the statement GUID and then go deeper, possibly using ">" in the selector.
  • The icons are not aligned. They are simply appended to the end of the values.
  • There is no default padding. Each icon added to the empty element should come with a good padding that works in both LTR and RTL contexts, e.g. "padding: 0 0.5em".

Bug: T95403
Change-Id: I8250979fd105f2b9a3eb1c4ab188e3df15bfcd1a

Details

Committed
Gerrit Code ReviewMay 5 2015, 1:39 PM
Parents
rMEXT0971f11d0fdb: Updated mediawiki/extensions Project: mediawiki/extensions/PageTriage…
Branches
Unknown
Tags
Unknown
ChangeId
I8250979fd105f2b9a3eb1c4ab188e3df15bfcd1a

Event Timeline

Gerrit Code Review <gerrit@wikimedia.org> committed rMEXTd6ac3d5bda96: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase… (authored by jenkins-bot <jenkins-bot@gerrit.wikimedia.org>).May 5 2015, 1:39 PM