Diffusion mediawiki-libs-Zest 8d22c0ce9397

Optimize ID attribute search, if the DOM implementation has indexed it
8d22c0ce9397
Actions

Tags

None

Referenced Files

None

Subscribers

None

Description

Optimize ID attribute search, if the DOM implementation has indexed it

There are a few gotchas in DOMDocument#getElementById() (see T215000
for discussion) so be extra careful and double-check the result.

Change-Id: Ie7dc1c969543136a8e4b48a2afa7c9e198938493

Details

Provenance

Authored on Mar 5 2019, 9:14 PM

Parents

rMLZE5552f635c0e8: Speed up Zest by 100x by not using DOMDocument#getElementsByTagName()

Branches

Unknown

Tags

Unknown

ChangeId

Ie7dc1c969543136a8e4b48a2afa7c9e198938493

Event Timeline

cscott committed rMLZE8d22c0ce9397: Optimize ID attribute search, if the DOM implementation has indexed it (authored by cscott).Mar 7 2019, 3:37 PM

Changes (2)

Path

Size

src/

tests/

rMLZE8d22c0ce9397

src/ZestInst.php

Loading...

tests/ZestTest.php

Loading...