HomePhabricator
Diffusion Scap 35e4dc6ea855

sync-wikiversion: don't overwrite AbstractSync

Authored by thcipriani on Aug 22 2018, 5:37 PM.

Description

sync-wikiversion: don't overwrite AbstractSync

Summary:
sync-wikiversions implements AbstractSync, but overwrites the main
method which clobbers much of the logic of AbstractSync. We ran into a
problem when AbstractSync was extended to include logic to sync masters.
Now AbstractSync supports canaries but sync-wikiversions does not.

Rather than add-in canary support for sync-wikiversions, I've opted to
have sync-wikiversions use AbstractSync's main method. This means that
sync-wikiversions will perform sync-masters, canary and proxy fan-out
steps which will make it slower, but hopefully safer.

Bug: T198640

Reviewers: mmodell, dduvall, bd808, Release-Engineering-Team

Reviewed By: mmodell, Release-Engineering-Team

Tags: Release-Engineering-Team

Differential Revision: https://phabricator.wikimedia.org/D1100

Details

Committed
thciprianiAug 24 2018, 7:15 PM
Reviewer
Release-Engineering-Team
Differential Revision
D1100: sync-wikiversion: don't overwrite AbstractSync
Parents
rMSCA4730e7a7d3f6: Bump number of shame
Branches
Unknown
Tags
Unknown
ChangeId
None
Build Status
Buildable 3095
Build 5174: ci-jessieJenkins