HomePhabricator
Diffusion Scap 3955f36fe41a

If git_repo isn't set, lock scap sync*

Authored by thcipriani on Sep 5 2017, 7:50 PM.

Description

If git_repo isn't set, lock scap sync*

Summary:
Since deployments for non-mediawiki repos require git_repo to be set, if
git_repo isn't set when creating a lock file, that lock file is to
prevent the deployment of the mediawiki repo.

This caused problems when the git_repo was set in
/srv/mediawiki-staging/scap/scap.cfg. Since scap only looks for
configuration files in /etc/scap.cfg and ./scap/scap.cfg when
deploying from /srv/mediawiki-staging git_repo was set creating the
lockfile /var/lock/scap.operations_mediawiki-config.lock; however,
when running scap sync from /srv/ (or anywhere other than
/srv/mediawiki-staging) scap looked for the lockfile
/var/lock/scap.unknown-but-probably-mediawiki.lock. This allowed
parallel deploys of mediawiki to happen under certain circumstances
which causes unforeseeable issues.

Fixes T175041

Reviewers: demon, mmodell, Release-Engineering-Team

Reviewed By: demon, mmodell, Release-Engineering-Team

Tags: Release-Engineering-Team

Maniphest Tasks: T175041

Differential Revision: https://phabricator.wikimedia.org/D767

Details

Committed
thciprianiSep 22 2017, 8:35 PM
Reviewer
Release-Engineering-Team
Differential Revision
D767: If git_repo isn't set, lock scap sync*
Parents
rMSCAb7dbba3881e5: Changes for require_valid_service
Branches
Unknown
Tags
Unknown
Tasks
T175041: scap sync failed on i18n
ChangeId
None
Build Status
Buildable 2269
Build 3671: ci-jessieJenkins