HomePhabricator
Diffusion Scap 93e9b27e809f

Stop using predefined built-in functions and such in scap code

Authored by GerritToPhabBot on Oct 23 2017, 10:40 PM.

Description

Stop using predefined built-in functions and such in scap code

Summary:
It's considered bad form, and when refactoring for this change it was
pretty clear why: minor changes like renaming a variable can lead to
subtle breakages. Additionally, it makes things easier to grep for when
you're doing refactors and other fun stuff

Reviewers: mmodell, Release-Engineering-Team

Reviewed By: mmodell, Release-Engineering-Team

Subscribers: jenkins

Tags: Release-Engineering-Team

Differential Revision: https://phabricator.wikimedia.org/D833