HomePhabricator
Diffusion Scap a3a8cf8c9934

Move restart_service to the end of the `promote`

Authored by thcipriani on Mar 14 2016, 11:38 PM.

Description

Move restart_service to the end of the promote

Projects: Release-Engineering-Team

Summary:
This moves the restart_service stage back to the end of promote. This:

  1. Avoids making an additional ssh connection to restart a service (even if no service is provided)
  2. There are services that may require a restart to being reading new code, which may make a separate restart stage difficult to handle.

This should retain the ability to run post-promote and post-service
restart check commands.

Also, adds the deploy --service-restart flag, to restart the service
via scap.

Reviewers: mmodell, demon, Release-Engineering-Team, dduvall

Reviewed By: Release-Engineering-Team, dduvall

Subscribers: jenkins

Differential Revision: https://phabricator.wikimedia.org/D148

Details

Committed
thciprianiMar 16 2016, 3:49 PM
Reviewer
Release-Engineering-Team
Differential Revision
D148: Move restart_service to the end of the `promote`
Parents
rMSCA0e5afd6e50c5: Remove user arguments from git operations
Branches
Unknown
Tags
Unknown
ChangeId
None