HomePhabricator
Diffusion Scap cf383313c013

All deploys use specific keyholder key

Authored by thcipriani on Sep 28 2017, 3:15 PM.

Description

All deploys use specific keyholder key

Summary:
The alphabetical ordering of keys in ssh-agent affects the order in
which keys are offered to remotes. MaxAuthTries is an sshd setting that
will raise a "Too many authentication failures" error after it has been
offered more than MaxAuthTries keys.

The function get_keyholder_key seems to do the right thing in all
deployed repos including MediaWiki. I added the additional configuration
variable mediawiki_keyholder_key to allow us to set the key for scap2
deployments without having scap3 repos inherit the configuration.

Reviewers: mmodell, demon, dduvall, Release-Engineering-Team

Reviewed By: mmodell, Release-Engineering-Team

Subscribers: jenkins, akosiaris

Tags: Release-Engineering-Team

Differential Revision: https://phabricator.wikimedia.org/D796

Details

Committed
thciprianiSep 28 2017, 4:17 PM
Reviewer
Release-Engineering-Team
Differential Revision
D796: All deploys use specific keyholder key
Parents
rMSCA3955f36fe41a: If git_repo isn't set, lock scap sync*
Branches
Unknown
Tags
Unknown
ChangeId
None
Build Status
Buildable 2292
Build 3718: ci-jessieJenkins