HomePhabricator

Add bulk test, and fix JobTimeout stalling the queue
74b39ee22ff3Unpublished

Authored by joakin <joaquin@chimeces.com> on Dec 17 2018, 6:56 PM.

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.
This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Add bulk test, and fix JobTimeout stalling the queue

The bulk test randomly generates jobs that will succeed, fail or time
out and then at the end it checks that the % distribution matches the
generation.

When running this test, every JobTimeout makes the queue loose one
running job, effectively reducing the concurrency of the queue. Since
we're not continuously adding jobs, it ends up stalling the queue when
it reaches concurrency 0.

To fix it, we call _processQueue at the finally of the promise returned
on push, given it the rejection of the JobTimeout bypasses the finally
call on _processJob.

WIP: The fix makes the running of the test a lot better (without that
fix it hangs around 400, with it around 900), but it still doesn't work
properly for some reason. Any help appreciated.

Bug: T212322
Change-Id: I3762fe2428f29471fec0b6975d904464320fe10b

Details

Committed
polishdeveloperDec 20 2018, 12:49 AM
Parents
rMSCRd61f005ffa8d: Fix coverage report job
Branches
Unknown
Tags
Unknown
ChangeId
I3762fe2428f29471fec0b6975d904464320fe10b

Event Timeline