HomePhabricator

Request w/o key does not 404 as expected

Authored by Eevans on Mar 5 2019, 7:05 PM.

Description

Request w/o key does not 404 as expected

There exists no validation for a key of zero length; Zero length keys
passed to Store#get result in a Cassandra query error, a status 500,
and a confusing error ('Key may not be empty').

This changeset adds validation to the key parser, and fixes the test.

Change-Id: I8820f1cc11b5b401a5246c55b634c1fceaa1496e

Details

Committed
EevansMar 5 2019, 7:15 PM
Parents
rMSKS0f19457b6af9: Use prometheus version 0.8.0
Branches
Unknown
Tags
Unknown
References
refs/changes/34/494534/1
ChangeId
I8820f1cc11b5b401a5246c55b634c1fceaa1496e