HomePhabricator

Make load* methods of DifferenceEngine idempotent

Authored by Tgr on Jul 11 2018, 8:48 AM.

Description

Make load* methods of DifferenceEngine idempotent

These methods returned a boolean indicating whether loading the
data was successful, but then always returned true on subsequent
calls. Fix that.

This changes public methods but there's no usage in Gerrit (some
of them are called but the return value is ignored), no use case
for a caller to care, and the previous behavior has been
undocumented and unreliable, so there is no deprecation period.

Change-Id: I3998aeea66972f33274e05fa5a74d6ce7fdc56b6

Details

Committed
TgrJul 18 2018, 6:03 AM
Parents
rMWe5d71f255289: Switch callers from ProcessCacheLRU to MapCacheLRU
Branches
Unknown
Tags
Unknown
References
refs/changes/36/445136/4
ChangeId
I3998aeea66972f33274e05fa5a74d6ce7fdc56b6