HomePhabricator

WANObjectCache: Change getWithSetCallback() signature to key/ttl/callback/opts

Authored by Krinkle.

Description

WANObjectCache: Change getWithSetCallback() signature to key/ttl/callback/opts

  • Put 'checkKeys' param in opts array instead of as a separate parameter. It's neat to not have to skip unnamed/positional arguments that are optional.
  • Move TTL to be before callback instead of after. This avoids dangling integers toward the bottom of a large code block that have no obvious meaning. Matches BagOStuff::getWithSetCallback.

Add unit test for lockTSE to confirm

Change-Id: I60d6b64fc5dff14108741bafe801fd1fde16d1df
(cherry picked from commit 09cbebb22439bf4223e87ceb3e42169dc85fd311)

Details

Committed
aaronOct 17 2015, 10:36 PM
Parents
rMW92d196fa5b10: Avoid exposure of local path in PNG thumbnails
Branches
Unknown
Tags
Unknown
ChangeId
I60d6b64fc5dff14108741bafe801fd1fde16d1df