HomePhabricator

ReverseChronologicalPager: Fix displaying date headers for non-revisions
38f33d34817bUnpublished

Unpublished Commit · Learn More

  • Publishing Disabled: All publishing is disabled for this repository.
  • Not On Permanent Ref: This commit is not an ancestor of any permanent ref.
This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

ReverseChronologicalPager: Fix displaying date headers for non-revisions

  • Add a way to disable grouping by dates. Previously they only appeared for pagers that paged by rev_timestamp, but now any subclasses of IndexPager could have date headers, and most of them don't expect that. Change the only three pagers that worked before to explicitly opt-in.
  • Fix an issue where some pagers had a stray </ul> tag at the beginning due to mismatched getStartGroup() and getEndGroup() calls.

Follow-up to ed63ede6575056e1d8ec3b28d4704152b8366f48.

Bug: T302343
Change-Id: I18822d249b2e04a7408f2cdc5375e84e411ffa26
(cherry picked from commit b96d235be1d00faf0c6af7d1cbf8493d63b3f904)

Details

Provenance
matmarexAuthored on Feb 22 2022, 8:46 PM
ChangeId
I18822d249b2e04a7408f2cdc5375e84e411ffa26

Commit No Longer Exists

This commit no longer exists in the repository.