HomePhabricator

rdbms: make LoadBalancer::reallyOpenConnection() handle setting DBO_TRX

Authored by aaron on Jul 14 2019, 10:43 PM.

Description

rdbms: make LoadBalancer::reallyOpenConnection() handle setting DBO_TRX

Make LoadBalancer::reallyOpenConnection() handle initializing DBO_TRX
instead of Database::__construct().

Also:

  • Avoid having the "catch" block appear like it returns a half-constructed Database.
  • Use the variable name $conn instead of $db to be consistent throughout the class. Only send Database::__construct() parameters that it recognizes instead of mixing in setLBInfo() data.

Change-Id: Iffc3d1d0713051a164adb51a4c4ee12e4ac887c3

Details

Committed
aaronAug 24 2019, 8:06 PM
Parents
rMW41355718e137: Merge "API: Warn about POST without Content-Type"
Branches
Unknown
Tags
Unknown
ChangeId
Iffc3d1d0713051a164adb51a4c4ee12e4ac887c3