Deprecate access of logos directly from config, introduce wgLogos
8cd2e1336354
Actions

Authored by Jdlrobson on Jan 7 2020, 7:18 PM.

Description

Deprecate access of logos directly from config, introduce wgLogos

Add getAvailableLogos static method and wgLogos config variable

Longterm we'll phase out wgLogo and wgLogoHD for this more extendable
config.

wgLogoHD is marked as deprecated. wgLogo continues to function as before
when wgLogos doesn't exist to cause minimum disruption.

From now on all logos should be accessed via getAvailableLogos. Patches
in Minerva and Vector follow. See I00899c16c0325f36b671baf17e88c2b5187b3526,
I569e0d800e147eabc7852567acd140108613f074 and
I013bd0904fe8c55efa49d14e84cf06ec1412896f.

Bug: T232140
Change-Id: I66a971631c623cc94b58eb0e5e5bad804789bf1c

Details

Committed

Jdlrobson

Feb 4 2020, 1:56 AM

Parents

rMW36ed224b8f40: Fix IndexPager documentation to use correct terms in query

Branches

Unknown

Tags

Unknown

ChangeId

I66a971631c623cc94b58eb0e5e5bad804789bf1c

Event Timeline

Jdforrester-WMF mentioned this in T244370: Beta: Undefined index: 1x in /srv/mediawiki-staging/php-master/includes/Setup.php on line 186.Feb 5 2020, 3:40 PM

gerritbot mentioned this in T232140: Separate out logo handling into square image logos and long text/wordmark banner logos.Feb 5 2020, 3:44 PM

matmarex mentioned this in T244405: PHP Notice: Undefined offset: 1 in ResourceLoaderSkinModule.php.Feb 5 2020, 9:04 PM

Changes (8)

				Path
	M			includes/DefaultSettings.php
	M			includes/Setup.php
	M			includes/api/ApiQuerySiteinfo.php
	M			includes/resourceloader/ResourceLoaderSkinModule.php
	M			includes/skins/Skin.php
	M			includes/skins/SkinTemplate.php
	M			tests/phpunit/includes/OutputPageTest.php
	M			tests/phpunit/includes/resourceloader/ResourceLoaderSkinModuleTest.php