HomePhabricator

Update git submodules
8f47c69aed05Unpublished

Unpublished Commit · Learn More

Publishing Disabled: All publishing is disabled for this repository.
This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Update git submodules

  • Update extensions/ContentTranslation from branch 'wmf/1.29.0-wmf.7'
    • Workaround to fix restoration for truncated section ids

      What this does not solve is:
      • Saving failures if strict mode enabled
      • Data loss if two sections have unique prefix when truncated

        What this solves:
      • Using the correct id to match sections during restoration
      • The restoration code to handle the weirds ids by not using $( '#' + uncontrolled input ) as selector. Replaced with document.getElementById or [id="uncontrolled input"].

        I changed test cases to use unique ids to make debugging easier. Also, setting the source revision id avoids JavaScript error that masks a real test failure.

        Bug: T154279 Change-Id: Ibc8d67b6ac6ff0947e5519db26b3666620d7d114 (cherry picked from commit b21908bf2d0f4cd946cef8b78f8fa5c46eae9104)

Details

Provenance
NikerabbitAuthored on Jan 4 2017, 8:35 AM
Gerrit Code Review <gerrit@wikimedia.org>Committed on Jan 5 2017, 2:11 PM
ChangeId
None

Commit No Longer Exists

This commit no longer exists in the repository.