HomePhabricator

Fix some issues with HTMLSelectAndOtherField default and validation
90b513d96e36Unpublished

Authored by Tchanders on Jun 13 2019, 7:04 PM.

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

Fix some issues with HTMLSelectAndOtherField default and validation

Bring HTMLSelectAndOtherField in line with other HTMLFormFields by
ensuring that the default value is of the correct type and passes
validation checks.

Also make sure HTMLSelectAndOtherField::validate checks for the
final value, if the field has required set to true.

Bug: T222170
Bug: T225860
Change-Id: I949ee3df2b1f597982cf522b149c54b8e79d59bc
(cherry picked from commit db9ff28e3ebe87ed965561d4458841b7aad095c9)

Details

Committed
KrinkleJun 17 2019, 6:53 PM
Parents
rMW49395fbe50d1: Update git submodules
Branches
Unknown
Tags
Unknown
References
refs/changes/74/517474/1
ChangeId
I949ee3df2b1f597982cf522b149c54b8e79d59bc