HomePhabricator

Updated mediawiki/core Project: mediawiki/extensions/WikidataPageBanner…

This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Updated mediawiki/core Project: mediawiki/extensions/WikidataPageBanner 4f9ee787bc6321d19f955be9811173b43db47cc4

Delay rendering of OOUI icons until banner rendering

Whereas Mustache templating library calls toString on any objects
passed to it, the API doesn't. This change delays the generation of
OOUI IconWidget until the rendering of the banner itself.

Changes:
A new method expandIconTemplateOptions is now responsible for generating
html for icon and is done at parse time.

Other changes:
In icon definitions remove icon prefix since its unnecessary information
Update tests

Bug: T111304
Change-Id: I7f81678226f9fca48345e31a00a126e34b552675

Details

Provenance
JdlrobsonAuthored on
Gerrit Code Review <gerrit@wikimedia.org>Committed on Sep 15 2015, 4:17 PM
ChangeId
I7f81678226f9fca48345e31a00a126e34b552675

Commit No Longer Exists

This commit no longer exists in the repository.