HomePhabricator

Allow PHP version check to execute on older versions of PHP
a5c4f45dacf7Unpublished

Unpublished Commit · Learn More

  • Publishing Disabled: All publishing is disabled for this repository.
  • Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

Allow PHP version check to execute on older versions of PHP

A change to update.php used the null coalesce (??) operator.
While this is normally fine, the code in question executes
before the PHP version check, and causes an unfriendly PHP
error rather than the intended helpful error. Use the older-style
isset() call instead, so that the PHP version check will get
a chance to execute.

Bug: T213893
Change-Id: I22e4a24bed9e0b29e08afc7b9468e7bfd81d7d57
(cherry picked from commit b8b2514940e0e3a52e9d27f5432cdbb4d7f0c8b5)

Details

Provenance
BPirkleAuthored on Jul 11 2019, 2:16 AM
KghblnCommitted on Jul 16 2019, 12:52 PM
Parents
rMW8e36379de902: Revert "rdbms: codify DatabaseDomain table "_" prefix convention"
Branches
Unknown
Tags
Unknown
ChangeId
I22e4a24bed9e0b29e08afc7b9468e7bfd81d7d57

Event Timeline