HomePhabricator

Maintenance: Don't modify mOptions in getOption
c1c3d59de8ceUnpublished

Unpublished Commit · Learn More

  • Publishing Disabled: All publishing is disabled for this repository.
  • Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

Maintenance: Don't modify mOptions in getOption

This makes hasOption stable and usable even after getOption.

Also getOption can now be called twice with different defaults.

Strictly speaking this is a breaking change, but the actual
behaviour is now closer to the expected/documented behaviour.

Bug: T275619
Change-Id: I65e32a7e1bc253f4b29378be6980c42e43f93032
(cherry picked from commit 070f94de80fd09d720f06ef070081957928d089b)

Details

Provenance
EsandersAuthored on Feb 24 2021, 1:56 PM
ReedyCommitted on Mar 17 2021, 8:48 PM
Parents
rMW2a1a1b6b5bd3: registration: Allow specifying immovable namespaces in extension.json
Branches
Unknown
Tags
Unknown
ChangeId
I65e32a7e1bc253f4b29378be6980c42e43f93032

Event Timeline