HomePhabricator

resourceloader: Set a TTL for minification cache entries

Authored by Krinkle.
This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

resourceloader: Set a TTL for minification cache entries

Follows-up 458e7cabbbafd. HHVM's APC cache doesn't have any
limitation or eviction logic. Thus entries without a TTL will
linger indefinitely.

At time of writing over 99% of APC entries were from "resourceloader:filter"
because there are far more unpopular resources than popular ones.

A fixed TTL is suboptimal as it will also cause popular resources
(e.g. startup module, or jquery) to be re-minified every day.

Beware this isn't one single minification. It's one minification,
for every JS/CSS resource, on every app server, for many different
lang/skin/config variations.

Bug: T104769
Change-Id: Ib62c320da0eeede68aad3f2294006ec7dcf1df55
(cherry picked from commit bdb4a243eabbbb7d0a29e99fd8ef341d37c8d9e7)

Details

Committed
KrinkleJul 7 2015, 6:54 PM
ChangeId
Ib62c320da0eeede68aad3f2294006ec7dcf1df55

Commit No Longer Exists

This commit no longer exists in the repository.