HomePhabricator

ActiveUsersPager: Fix ordering and return 0-action users
f929e2a50696Unpublished

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.
This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

ActiveUsersPager: Fix ordering and return 0-action users

Ia9d2ff00 introduced two incompatibilities with what the base classes
were trying to do:

  • The $descending flag passed to buildQueryInfo() does not actually mean DESC if $this->mIsBackwards is set. The old code just blindly assumed that was the case.
  • For paging to work right, we must return all $limit rows, we can't filter out users with 0 actions. Thus we need to LEFT JOIN recentchanges (and move some conditions around to cope)..

Bug: T217525
Change-Id: Iba105a31ff61fbb14931bf8903538bfe7b0ba48b
(cherry picked from commit f74efe7fec180e9c4d1a730539f293711adb7939)

Details

Provenance
AnomieAuthored on Mar 4 2019, 4:01 AM
aaronCommitted on Mar 6 2019, 11:04 PM
ChangeId
Iba105a31ff61fbb14931bf8903538bfe7b0ba48b

Commit No Longer Exists

This commit no longer exists in the repository.