HomePhabricator

MessageCache: Restore 'loadedLanguages' tracking for load()
fa817b088e43Unpublished

Authored by Krinkle on Jul 29 2019, 6:22 PM.

Unpublished Commit · Learn More

  • Publishing Disabled: All publishing is disabled for this repository.
  • Not On Permanent Ref: This commit is not an ancestor of any permanent ref.
This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

MessageCache: Restore 'loadedLanguages' tracking for load()

This was removed in 97e86d934b3 in 2018 in favour of using
$this->cache->has($code). This is a problem because there
are cases where only a narrow subset of that structure is
populated (by MessageCache->replace) without things like
$this->overridable (or anything else that MessageCache->load does)
having ocurred yet.

The assumption that keys are only added to $this->cache by
MessageCache->load (or after that method has been called) was
actually true at some point. But, this changed in 2017 when
commit c962b480568e optimised MessageCache->replace to not call
MessageCache->load.

Bug: T208897
Change-Id: Ie8bb4a4793675e5f1454e65c427f3100035c8b4d

Details

Committed
KrinkleJul 29 2019, 9:38 PM
ChangeId
Ie8bb4a4793675e5f1454e65c427f3100035c8b4d

Commit No Longer Exists

This commit no longer exists in the repository.