HomePhabricator

(bug 37331) Modules sometimes execute twice in Firefox
fbab9100389dUnpublished

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.
This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

(bug 37331) Modules sometimes execute twice in Firefox

This seems to have been caused by a weird race condition that caused the
loader to run while the module in question was also running; could also
have been caused by the module calling mw.loader, but that didn't seem
to be the case here.

The fix is to set .state='ready' before executing the module rather than
after. We can't do this in debug mode (where we're loading raw files and
can't execute things at will), but we have to do this in production
mode to prevent these freakish double executions.

Change-Id: I7e8dbd361fb265e520d3935e3a1fc7e3b6710b66

Details

Provenance
CatropeAuthored on Jul 24 2012, 8:24 PM
ChangeId
I7e8dbd361fb265e520d3935e3a1fc7e3b6710b66

Commit No Longer Exists

This commit no longer exists in the repository.