HomePhabricator

pkg/rules: consider group name and file for deduplication (#3024)

Authored by Sergiusz Urbaniak <sergiusz.urbaniak@gmail.com> on Aug 13 2020, 5:13 AM.

Description

pkg/rules: consider group name and file for deduplication (#3024)

Currently only the group name is considered for group deduplication.
However prometheus uses also the group file according to [1].

This fixes it.

[1] https://github.com/prometheus/prometheus/blob/ce838ad6fcbd14b0cf9971a4d093ad672e1469fe/rules/manager.go#L1047-L1055

Signed-off-by: Sergiusz Urbaniak <sergiusz.urbaniak@gmail.com>

Details

Committed
GitHub <noreply@github.com>Aug 13 2020, 5:13 AM
Parents
rODTHd6305f5920c4: mixin: Fix alert about unhealthy sidecar (#2929)
Branches
Unknown
Tags
Unknown
ChangeId
None

Event Timeline

GitHub <noreply@github.com> committed rODTHe8962b7bf07c: pkg/rules: consider group name and file for deduplication (#3024) (authored by Sergiusz Urbaniak <sergiusz.urbaniak@gmail.com>).Aug 13 2020, 5:13 AM