HomePhabricator

Revert "filtered_tables: Add new columns"
188a50fa82a0Unpublished

Unpublished Commit · Learn More

Publishing Disabled: All publishing is disabled for this repository.

Description

Revert "filtered_tables: Add new columns"

This reverts commit 143db27557b27d0b0b41030f9ba600de4fcbcc67.

Change-Id: If3a84a6ce1bcd5a806fdc30ba2064928e8365cf9

Details

Provenance
MarosteguiAuthored on Nov 30 2017, 8:36 AM
Parents
rOPUP143db27557b2: filtered_tables: Add new columns
Branches
Unknown
Tags
Unknown
Reverts
rOPUP143db27557b2: filtered_tables: Add new columns
ChangeId
If3a84a6ce1bcd5a806fdc30ba2064928e8365cf9

Event Timeline

@Marostegui why did this change happen? It makes filtered_tables.txt ignore the new fields, like ar_comment_id (which should be filtered out). It did seem incomplete, for example it's not adding fields like rev_comment_id, but there are no more recent changes that update it. I'm happy to generate a new version and submit it with my best guess for K/F, would that help?

@Marostegui why did this change happen? It makes filtered_tables.txt ignore the new fields, like ar_comment_id (which should be filtered out). It did seem incomplete, for example it's not adding fields like rev_comment_id, but there are no more recent changes that update it. I'm happy to generate a new version and submit it with my best guess for K/F, would that help?

It is explained here: https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/393725/

Marostegui
Nov 30, 2017
↩
Patch Set 4:

Actually, I think I am going to revert this and leave it pending to merge, otherwise private_data check will complain until we do all the sanitization. 
So better to wait until the sanitization can be done all at once.

And once they were added&sanitized it was pushed again: https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/394254/