HomePhabricator

Gerrit: Avoid breaking full phabricator URLs
fcaae0d53d72Unpublished

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.
This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Gerrit: Avoid breaking full phabricator URLs

What this fix does is it fixes this

T12345" target="_blank">https://phabricator.wikimedia.org/T12345

so that it will look like

https://phabricator.wikimedia.org/T12345

Also this dosent affect plain text for T1 so that will still link
correctly

This regex is from @Thiemo Mättig (WMDE)

But one thing i found in testing is that it will higligh

https://phabricator.wikimedia.org/ and T12345 seperatly but will still
link correctly to the right website. It should not be noticable unless
someone hovers over it.

This seems to be the best fix we can do for this without having to break
other links in the process.

Thanks @Thiemo Mättig (WMDE) for your suggestion here
https://gerrit.wikimedia.org/r/#/c/242237/2/modules/gerrit/templates/gerrit.config.erb

Bug: T75997
Change-Id: I69be5bf547bf0017902db67b56cea9234d37aabb

Details

Provenance
PaladoxAuthored on Jul 31 2016, 6:06 PM
ChangeId
I69be5bf547bf0017902db67b56cea9234d37aabb

Commit No Longer Exists

This commit no longer exists in the repository.