HomePhabricator

CallsNative flag on ir opcodes should imply MayRaiseError by default

Authored by swtaarrs.

Description

CallsNative flag on ir opcodes should imply MayRaiseError by default

Summary: We've been burned in the past by opcodes that can throw but weren't
marked as such. MayRaiseError is now opt-out on CallsNative opcodes, by using
NNE instead of N. I tried to audit each one that broke because of this and make
the right choise wrt NNE vs. adding a catch block.

Reviewed By: @bertmaher

Differential Revision: D1400014

Details

Committed
facebook-github-botJun 24 2014, 10:30 PM
Parents
rOSHDc0f64820c79c: Revert "[hack] don't recompute files with errors"
Branches
Unknown
Tags
Unknown
ChangeId
None

Event Timeline