HomePhabricator

Clean up some tracing and asserts

Authored by swtaarrs.

Description

Clean up some tracing and asserts

Summary: I added all of this while debugging various issues and figured it'd be
generally useful.

  • Convert unwind.cpp to use ITRACE.
  • Assert that spoff is correct on tracelet entry.
  • Use visitStackElems to verify stack contents in checkFrame.
  • Fix RBTrace codegen for code relocation by using rip-relative lea

Closes https://github.com/facebook/hhvm/pull/3219

Reviewed By: @bertmaher

Differential Revision: D1443194

Pulled By: @swtaarrs

Details

Committed
facebook-github-botAug 4 2014, 12:30 AM
Parents
rOSHD8394168e513a: break out hhvm request timeout / memout counters for psp vs non-psp
Branches
Unknown
Tags
Unknown
ChangeId
None

Event Timeline

facebook-github-bot <githubbot@fb.com> committed rOSHDf4e77b17c79c: Clean up some tracing and asserts (authored by swtaarrs).Aug 4 2014, 12:30 AM