HomePhabricator

Namespace all column references in ProjectQuery to fix ambiguity with Ferret…

Description

Namespace all column references in ProjectQuery to fix ambiguity with Ferret constraints

Summary:
Fixes T13378. If we join Ferret tables and page, we can end up with an ambiguous id column here.

Explicitly refer to "project.x" in all cases that we're interacting with the project table.

Test Plan:

  • Changed page size to 3.
  • Issued a Projects query for "~e", matching more than 3 results.
  • Clicked "Next Page".
    • Before: ambiguous id column fatal.
    • After: next page.

Maniphest Tasks: T13378

Differential Revision: https://secure.phabricator.com/D20714

Details

Provenance
epriestleyAuthored on Aug 15 2019, 7:00 PM
Parents
rPHAB82cf97ad65a9: When many commits are discovered at once, import them at lower priority
Branches
Unknown
Tags
Unknown
ChangeId
None

Event Timeline