HomePhabricator

Updated git submodules
154b6d406de8Unpublished

Authored by mmodell on Nov 10 2016, 1:29 AM.

Unpublished Commit · Learn More

Publishing Disabled: All publishing is disabled for this repository.

Description

Updated git submodules

Project: phabricator/libphutil wmf/stable 11caa90f8e835b7af5bf929b35751b9c761977bd

Merge remote-tracking branch 'upstream/stable' into wmf/stable

(stable) Promote 2016 Week 45

When we encounter a fanciful timezone identifier, try to guess what it might mean

Summary:
Ref T11816. My read of RFC 5545 is that applications can do whatever they want here. Although most applications use legal timezonedb values like "America/Los_Angeles", at least one ("Zimbra") has at least one event with a weird value (TZID="(GMT-05.00) Auto-Detected").

Try to puzzle out what these mysterious identifiers might intend. For now, I added a rule to look for "UTC+3", "GMT-2:30", etc.

If we don't have any guesses, just use UTC. If we guess or fall back, raise a warning so the user can see what happened.

Test Plan: Added a unit test. See also next change.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11816

Differential Revision: https://secure.phabricator.com/D16800

Add some stricter casts to PhutilCalendarAbsoluteDateTime serialization

Summary: Ref T11805. This fixes a future issue with comparing edited values: false and 0 were being considered to be an edit.

Test Plan: See next change.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11805

Differential Revision: https://secure.phabricator.com/D16785

Fix an issue importing instantaneous events

Summary: Ref T10747. It's possible to define instantaneous events (no end date or duration) but we currently fail when trying to import them.

Test Plan: Imported an instantaneous event.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10747

Differential Revision: https://secure.phabricator.com/D16767

(stable) Promote 2016 Week 44

Parse (and discard) VALARM sections in ICS files

Summary:
Ref T10747. Ref T11790. These sections may legally appear inside VEVENT sections.

For now, parse but discard them. At least for now, we assume whatever you're importing from is authoritative and handles notifying you if you're importing events.

(It also probably makes more sense to set per-import or per-user notification settings than trust VALARMS? But we can cross that bridge when we come to it.)

Test Plan: Added unit tests.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10747, T11790

Differential Revision: https://secure.phabricator.com/D16761

When importing ICS events, also import attendees

Summary: Ref T10747. This imports the generic user nodes from ICS files so we can convert them into event attendees. See D16759.

Test Plan: See D16759.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10747

Differential Revision: https://secure.phabricator.com/D16760

Add a method to drop all PhutilClassMap caches

Summary:
The addition of "preflight" setup checks caused us to generate a setup check cache early, and stop running third-party setup checks (these are rare, but we have a couple in Phacility stuff).

Add a method so we can drop caches explicitly.

The next change drops caches in Phabricator after loading libraries.

Test Plan: See next diff.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D16755

Fix import casts for RRULE "INTERVAL" and "COUNT" properties

Summary: Ref T10747. When present, these should both be integers.

Test Plan: Imported an event repeating 5 times, every other day.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10747

Differential Revision: https://secure.phabricator.com/D16748

(stable) Promote 2016 Week 43

Fix some minor parsing bugs in ICS parser

Summary: Ref T10747. Cleans up some integer/property handling a touch.

Test Plan: Imported more complex ICS events.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10747

Differential Revision: https://secure.phabricator.com/D16729

Import RRULEs when parsing Calendar events

Summary: Ref T10747. This hooks up RRULE, which we already parse.

Test Plan: Imported a recurring event.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10747

Differential Revision: https://secure.phabricator.com/D16715

Fix some libphutil Calendar document bugs

Summary:
Ref T10747.

  • Default to UTC if a datetime has no explicit timezone.
  • Fix a bug with escape detection that could incorrectly trigger for escaped commas.
  • Remove some unused properties (now properites of the RRULE itself).

Test Plan: See next diff.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10747

Differential Revision: https://secure.phabricator.com/D16698

Details

Committed
Gerrit Code Review <gerrit@wikimedia.org>Nov 10 2016, 6:45 PM
Parents
rPHDEP53c6b5383216: Updated git submodules
Branches
Unknown
Tags
Unknown
ChangeId
None

Event Timeline

Gerrit Code Review <gerrit@wikimedia.org> committed rPHDEP154b6d406de8: Updated git submodules (authored by mmodell).Nov 10 2016, 6:45 PM