HomePhabricator

handle ?diff=1 on /r/revision/ url redirection

Authored by mmodell on Jun 14 2016, 12:22 AM.

Description

handle ?diff=1 on /r/revision/ url redirection

Maniphest Tasks: T137224

Summary:
This is needed so we can redirect gitblit /patch/* urls to
diffusion. (see T137224#2376481)

These are all valid now:

  • /r/revision/$project;hash?diff=1
  • /r/patch/$project;$hash
  • /r/commit/$project;$hash
  • /r/commit/$project;$hash?patch

refs T137224

Test Plan: doing it live

Reviewers: Danny_B, Paladox

Reviewed By: Paladox

Subscribers: Paladox

Differential Revision: https://phabricator.wikimedia.org/D265

Details

Auditors
mmodell
Group Auditors
Restricted Owners Package
Committed
mmodellJun 14 2016, 12:49 AM
Reviewer
Paladox
Differential Revision
D265: handle ?diff=1 on /r/revision/ url redirection
Parents
rPHEXf8962a58d7e6: Explicitly convert url object to string
Branches
Unknown
Tags
Unknown
Tasks
T137224: Redirect Gitblit urls (git.wikimedia.org) -> Diffusion urls (phabricator.wikimedia.org/diffusion)
ChangeId
None
Build Status
Buildable 591
Build 892: ci-jessieJenkins