HomePhabricator

Update git submodules

Authored by pmiazga on Jul 25 2019, 10:34 AM.

Description

Update git submodules

  • Update MinervaNeue from branch 'master' to ad04f31441c0f044480bc31ee2368e070aaa161f
    • Follow-up: User menu improvements

      Changes:
      • We should limit the interfaces we pass around, AdvancedUserMenuBuilder doesn't need whole IContextSource as it uses only msg() method. It's better to define that this methods needs only MessageLocalizer
      • move UserMenuDirector into ServiceWiring to be consistent with other Directors/Builders
      • pass PersonalTools as a dependency to UserMenuDirector, which will pass to each Builder. The personalTools is set of links that can/should be used when rendering user menu (which in the fact has almost same subset of tools as the personal toolbox)

        Bug: T214540 Change-Id: I7f744651b0665452a5a9d1ce661f20547e80812d

Details

Committed
Gerrit Code Review <gerrit@wikimedia.org>Jul 25 2019, 2:54 PM
Parents
rSKINecc9f52c9675: Update git submodules
Branches
Unknown
Tags
Unknown
ChangeId
None

Event Timeline

Gerrit Code Review <gerrit@wikimedia.org> committed rSKIN99ecfc1d15dd: Update git submodules (authored by pmiazga).Jul 25 2019, 2:54 PM