HomePhabricator

New infrastructure for actions, as discussed on wikitech-l. Fairly huge commit.

Description

New infrastructure for actions, as discussed on wikitech-l. Fairly huge commit.

  • Actions come in two flavours: the show-a-form-then-do-something-with-the-result (delete, protect, edit, etc) and the just-do-something (watch, rollback, patrol, etc). Create abstract base classes Action and FormlessAction to support these two cases. HTMLForm is an integral part of the form-based structure.
  • Look mum, no globals! :D Fully context-based.
  • Implement watch/unwatch, credits and delete actions in the new system as proof-of-concept. This also gives the delete frontend a much-needed overhaul.
  • Stub out the newly-deprecated functions from Article.php. This already reduces its linecount by about 15%, and there are plenty more actions still to do.
  • Centralising actions like this is going to render a lot of hooks type-incompatible. There's simply nowhere you can put the ArticleConfirmDelete hook, for instance, where it can be passed an OutputPage as the second parameter. On the other hand, we can implement new hooks like ActionModifyFormFields and ActionBeforeFormDisplay, which can do much prettier stuff to the forms, like adding extra fields the 'right' way. Update LiquidThreads to use these new hooks where appropriate.

Details

Committed
happy-melonApr 13 2011, 11:04 PM
Parents
rSVN86000: ArticleFeedback: Followup r85998: per Trevor, don't count ratings with value…
Branches
Unknown
Tags
Unknown
ChangeId
None