HomePhabricator

Removed $wgProto. Previously, setting this undocumented global variable to…

Description

Removed $wgProto. Previously, setting this undocumented global variable to anything other than the part of $wgServer before the first colon would cause various things to subtly screw up. Similarly, forgetting to set it when you override $wgServer in LocalSettings.php would break things too.

Exposing it in the default LocalSettings.php as I did in r90105 was not a good solution, really the only way to avoid breakage is to just get the protocol from $wgServer whenever you need the protocol.

Fixed $wgCookieSecure so that it will be enabled automatically if the user sets $wgServer to an https URL in LocalSettings.php. Added documentation for other cookie-related globals.

Grep indicates that $wgProto is not used by any extensions. $wgCookieSecure is used, hence the need for the Setup.php patch.

Details

Committed
tstarlingJun 16 2011, 5:13 AM
Parents
rSVN90192: Followup to r89452, remove ftp test cases since Http::isValidUri() doesn't do…
Branches
Unknown
Tags
Unknown
ChangeId
None