Diffusion labs-tool-heritage 8187df623643

Lint SQL files using php-sqllint
8187df623643
Actions

Tags

None

Referenced Files

None

Subscribers

None

Description

Lint SQL files using php-sqllint

Do not write 'connect' line from 'create_tables*' sql files: it breaks linting, and is not needed as we always explicitly connect to the database when using them when necessary.
Remove the workaround in Dockerfile (as removed per above)
Add cweiske/php-sqllint to composer.json
Add secure-http config option (otherwise install fails)

Bug: T132641
Change-Id: I9e4bb96d9ddb2f090e704df3207b4c5f01027ac8

Details

Provenance

Authored on Oct 11 2016, 10:21 AM

Parents

rTHERf0a4482067af: Merge "Re-factor test of getCommonscatTemplates"

Branches

Unknown

Tags

Unknown

References

refs/changes/26/315226/2

ChangeId

I9e4bb96d9ddb2f090e704df3207b4c5f01027ac8

Event Timeline

JeanFred committed rTHER8187df623643: Lint SQL files using php-sqllint (authored by JeanFred).Oct 11 2016, 12:59 PM

Stashbot mentioned this in T145333: Break down monuments_config in individual JSON files.Oct 12 2016, 9:15 AM

Stashbot mentioned this in T145574: update TestGetCommonsCatTemplates to mock _load_wikipedia_commonscat_templates().

Stashbot mentioned this in T143573: Add Nigeria to database.

Stashbot mentioned this in T132641: Standardise SQL formatting and lint .sql files at CI.

Stashbot mentioned this in T138633: improve logging.

Changes (3)

Path

Size

conf/

Dockerfile.dbempty

erfgoedbot/

monument_tables.py

rTHER8187df623643

composer.json

Loading...

conf/Dockerfile.dbempty

Loading...

erfgoedbot/monument_tables.py

Loading...