HomePhabricator

Update patch set 6
128563f30799Unpublished

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

Update patch set 6

Patch Set 6:

I’m afraid this doesn’t at all fix the problem I meant to report in

> T189146… perhaps I made the task too unclear :) but consider, for
> example, this query:
>
> #defaultView:ImageGrid
> SELECT * WHERE {
> BIND(wd:Q42 AS ?item)
> ?item wdt:P18 ?image.
> BIND("lorem ipsum dolor sit amet, consectetur adipiscing elit…" AS
> ?text)
> }
>
> The overflowing text I was referring to is ?text, but this patch
> fixes the overflowing path of ?image.

thankyou @Lucas Werkmeister (WMDE) for the review. I misunderstood text as image name which is also being truncated sometimes. Sorry for the above patch. As mentioned in the description at phabricator, a tooltip has to display on hovering image description. But the description has two parts

  1. link to an image
  2. link to the item

can you specify on hovering which part should it display a tooltip?

Patch-set: 6
Label: Verified=0

Details

Provenance
RammanojpotlaAuthored on Mar 19 2018, 11:40 AM
Gerrit Code Review <gerrit@wikimedia.org>Committed on Mar 19 2018, 11:40 AM
Parents
rWDQG43a682f93e9b: Update patch set 6
Branches
Unknown
Tags
Unknown
ChangeId
None

Empty Commit

This commit is empty and does not affect any paths.