HomePhabricator

Update patch set 4
351c8fc69907Unpublished

Authored by prssanna on Jun 1 2018, 5:21 PM.

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

Update patch set 4

Patch Set 4:

I tried this out, and it looks like the dialog has some padding

> > which is not fully opaque, so you can see elements behind it:
> > https://i.imgur.com/shGlJNC.png (please excuse the terrible
> > drawing)
>
> Haha no problem, I'll fix that, though that's how it is on the
> website currently! Also do you have any suggestions for how to
> indicate to the user that there are multiple open dialogs?

Patch-set: 4
Label: Verified=0

Details

Committed
Gerrit Code Review <gerrit@wikimedia.org>Jun 1 2018, 5:21 PM
Parents
rWDQGb0cbaf40ae81: Update patch set 4
Branches
Unknown
Tags
Unknown
ChangeId
None

Event Timeline

Gerrit Code Review <gerrit@wikimedia.org> committed rWDQG351c8fc69907: Update patch set 4 (authored by prssanna).Jun 1 2018, 5:21 PM

Empty Commit

This commit is empty and does not affect any paths.