HomePhabricator

Update patch set 4
35b2b41c91cbUnpublished

Authored by Aleksey_WMDE on Jun 28 2017, 2:05 PM.

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

Update patch set 4

Patch Set 4: Verified-1

(1 comment)

This patch looks like what you might expect it should look, but what happens if user submits the query?
Browser downloads an XML file.
For Cats query it looks like this:

<sparql>
  <head>
    <variable name="item"/>
    <variable name="itemLabel"/>
  </head>
  <results>
    <result>
      <binding name="item"><uri>http://www.wikidata.org/entity/Q25471040</uri></binding>
      <binding name="itemLabel"><literal xml:lang="en">Pixel</literal></binding>
    </result>
    ...
  </results>
</sparql>

What is the use of that?

I don't think we should merge this patch because for now it is almost useless, IMO.
I would rather have big red banner saying: "Enable JavaScript or it won't work!".

Or, do a proper rendering, but that requires server-side part and is simply not there for this project.

Patch-set: 4
Reviewer: Aleksey Bekh-Ivanov (WMDE) <4089@e9e9afe9-4712-486d-8885-f54b72dd1951>
Label: Verified=0

Details

Committed
Gerrit Code Review <gerrit@wikimedia.org>Jun 28 2017, 2:05 PM
Parents
rWDQG6dfb38e43214: Update patch set 4
Branches
Unknown
Tags
Unknown
ChangeId
None

Event Timeline

Gerrit Code Review <gerrit@wikimedia.org> committed rWDQG35b2b41c91cb: Update patch set 4 (authored by Aleksey_WMDE).Jun 28 2017, 2:05 PM