HomePhabricator

Update patch set 4
3fe8b6d9f72aUnpublished

Authored by Lucas_Werkmeister_WMDE on Jul 20 2017, 2:07 PM.

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

Update patch set 4

Patch Set 4:

(4 comments)

This is super ugly. Perhaps we should use [fscreen]?

I’m also not convinced this is a useful button… it does exactly the same thing as the browser’s F11, which is an already established shortcut. And I don’t know if it’s a good idea to override that one in the query editor, either.

[fscreen]: https://github.com/rafrex/fscreen

Patch-set: 4

Details

Committed
Gerrit Code Review <gerrit@wikimedia.org>Jul 20 2017, 2:07 PM
Parents
rWDQG9d434c76c6a6: Update patch set 4
Branches
Unknown
Tags
Unknown
ChangeId
None

Event Timeline

Gerrit Code Review <gerrit@wikimedia.org> committed rWDQG3fe8b6d9f72a: Update patch set 4 (authored by Lucas_Werkmeister_WMDE).Jul 20 2017, 2:07 PM