HomePhabricator

Update patch set 1
736b8d5dc418Unpublished

Authored by thiemowmde on Sep 1 2017, 7:06 AM.

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

Update patch set 1

Patch Set 1: Code-Review-1

(1 comment)

The problem is not here, in this code, but in the CSS of https://tools.wmflabs.org/scholia/author/Q27061849 . The <div> container there that is meant to display the dimensions graph does not have any size constraints. The result browser does it's best to guess what the dimensions might be, and calculates a number, but this number changes immediately the moment the graph is attached to the <div>. The <div> changes size and starts showing scrollbars, and these reduce the width (but not the height).

Note this is different depending on the operating system. As far as I know the scrollbars on Apple touch devices do not consume space.

Much better solution: Set a fixed height on the <div> container, and set "overflow: hidden" just to be sure.

Patch-set: 1
Label: Code-Review=-1

Details

Committed
Gerrit Code Review <gerrit@wikimedia.org>Sep 1 2017, 7:06 AM
Parents
rWDQG8353169aefe8: Update patch set 1
Branches
Unknown
Tags
Unknown
ChangeId
None

Event Timeline

Gerrit Code Review <gerrit@wikimedia.org> committed rWDQG736b8d5dc418: Update patch set 1 (authored by thiemowmde).Sep 1 2017, 7:06 AM