HomePhabricator

Update patch set 9
946b7499a773Unpublished

Authored by prssanna on Jun 4 2018, 7:27 PM.

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

Update patch set 9

Patch Set 9:

(3 comments)

>
> Looks much better now, thank you :)
>
> > do you have any suggestions for how to indicate to the user know
> that there are multiple open dialogs?
>
> I think it would be nice to avoid opening them all at the same
> location, i. e. if there’s one dialog already open at the default
> location, offset the next one by (100px,100px), the next one after
> that at (200px,200px), etc., or something like that.
>
> One minor thing I noticed: when you change the result view in one
> of the dialogs, the “edit this query” link moves around – for
> example, when switching to Table view, it moves up on top of the
> first result. https://screenshotscdn.firefoxusercontent.com/images/8f66d6c2-afba-4068-adf5-19c7f3ac5e2a.png

I fixed that issue! Thanks for the suggestion, I've implemented it like that, let me know if it looks okay!

Patch-set: 9
Reviewer: Prssanna <5787@e9e9afe9-4712-486d-8885-f54b72dd1951>
Label: Verified=0

Details

Committed
Gerrit Code Review <gerrit@wikimedia.org>Jun 4 2018, 7:27 PM
Parents
rWDQGbd82f8398d38: Update patch set 9
Branches
Unknown
Tags
Unknown
ChangeId
None

Event Timeline

Gerrit Code Review <gerrit@wikimedia.org> committed rWDQG946b7499a773: Update patch set 9 (authored by prssanna).Jun 4 2018, 7:27 PM

Empty Commit

This commit is empty and does not affect any paths.