HomePhabricator

Update patch set 2
b46331dd38a0Unpublished

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

Update patch set 2

Patch Set 2:

Ah, right, I forgot about the "+" icon – good point, thanks! In

> that case we need a separate span, yes. But in that case the other
> comment about using this._i18n instead of the fixed strings
> "Filter" and "Show" still applies :)

Thankyou @Lucas Werkmeister (WMDE) for the reply. Yes, "Filter" should not be fixed there I missed the point. However, thank you for comment on it. The new patchset works fine locally

Patch-set: 2
Reviewer: Rammanojpotla <4632@e9e9afe9-4712-486d-8885-f54b72dd1951>
Label: Verified=0

Details

Provenance
RammanojpotlaAuthored on Mar 19 2018, 2:31 PM
Gerrit Code Review <gerrit@wikimedia.org>Committed on Mar 19 2018, 2:31 PM
Parents
rWDQGb3ff33ec654e: Create patch set 2
Branches
Unknown
Tags
Unknown
ChangeId
None

Empty Commit

This commit is empty and does not affect any paths.