HomePhabricator

Update patch set 5
bc5bbc405daaUnpublished

Authored by prssanna on Mar 13 2018, 2:07 PM.

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

Update patch set 5

Patch Set 5:

(1 comment)

I had commented out line 826 because if the query is empty, the else block is not executed and so the button would have remained disabled. Since I removed that line I had also removed 843 as it is then no longer required.

However, I realise that disabling the button while the query is running is necessary, so I have added those lines again and added an extra line to enable the button again in case of an empty query.

Patch-set: 5
Reviewer: Prssanna <5787@e9e9afe9-4712-486d-8885-f54b72dd1951>
Label: Verified=0

Details

Committed
Gerrit Code Review <gerrit@wikimedia.org>Mar 13 2018, 2:07 PM
Parents
rWDQG787a0707ee33: Create patch set 5
Branches
Unknown
Tags
Unknown
ChangeId
None

Event Timeline

Gerrit Code Review <gerrit@wikimedia.org> committed rWDQGbc5bbc405daa: Update patch set 5 (authored by prssanna).Mar 13 2018, 2:07 PM

Empty Commit

This commit is empty and does not affect any paths.